CMS Made Simple Forums
https://forum.cmsmadesimple.org/

[closed] Path separators in DisplayImage()
https://forum.cmsmadesimple.org/viewtopic.php?f=75&t=56862
Page 1 of 1

Author:  tomphantoo [ Tue Sep 20, 2011 8:08 am ]
Post subject:  [closed] Path separators in DisplayImage()

There are quite a few instances of hardcoded path separator '/' in DisplayImage() (in file class.admintheme.inc.php).

It seems that this func deals with paths, not URL's, and in that case, should the separators be DIRECTORY_SEPARATOR ?

Same for 1.9.

Author:  Rolf [ Fri Sep 23, 2011 4:13 pm ]
Post subject:  Re: Path separators in DisplayImage()

tomphantoo \tomphantoo:
There are quite a few instances of hardcoded path separator '/' in DisplayImage() (in file class.admintheme.inc.php).

It seems that this func deals with paths, not URL's, and in that case, should the separators be DIRECTORY_SEPARATOR ?

Same for 1.9.

We don't think hardcoded '/' would cause any problems, even now in Windoze ;)

Rolf

Page 1 of 1 All times are UTC
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
http://www.phpbb.com/