CMS Made Simple Forums

Do any of you have experience with, and/or can you suggest a use-case for, CMSModule::CreateReturnLink() ?

I'm wondering because the method produces a string with an embedded URL which can be partially-'entitized' (not e.g. urlencoded). I think such anchor would (if actually modified) be unusable verbatim in a browser. Nor would the $onlyhref-returned URL be usable as-is.

Ditto for CMSModule::create_url().

Should we correct something here?

I would not use any PHP method for creating a 'link', and consider all of them to be 'legacy code'.

Bettter solution is to to give URL's to smarty and then build the link tag, or whatever else (javascript etc). in the template.

Whether the function is buggy or not is irrelevant. consider that the URL is your 'data' give it to smarty to render it as a link or whatever inside your template.