Announcing CMS Made Simple v1.4 "Jamaica"

RonnyK · **Posted:** Mon Aug 04, 2008 12:44 pm

mikeim,

AFAIK, for point 2.

Theseare inactive files, as for the security release that was done earlier, it was required to overwrite the file with logic, with a dummy-file, because people upgrading, would otherwise remain with the vulnerable files....

Ronny

Nick Smart · **Posted:** Mon Aug 04, 2008 1:11 pm

stopsatgreen wrote:

Have just found a rather large problem with one of my installs; {stylesheet name='Name'} no longer works. Have tried a number of different tests, so far to no avail; it's just stopped working since upgrading to 1.4.

I've just had exactly the same thing. I tried re-unpacking the install, attaching and de-attaching the stylesheet, playing with the config options - process_whole_template and old_stylesheet - to no-avail. In the end I just chaged the template to say {stylesheet}, making sure the style was linked to the template, and it worked fine.

Nick

stopsatgreen · **Posted:** Mon Aug 04, 2008 1:43 pm

Nick Smart wrote:

In the end I just chaged the template to say {stylesheet}, making sure the style was linked to the template, and it worked fine.

That's not an ideal solution, though, because it means creating more templates. I want to have as few templates as possible and use individual stylesheets on some;

Code:

{if $page_alias == 'page1' || $page_alias == 'page2'}
{stylesheet name='sheetname'}
{/if}

One of my sites relies quite heavily on that

I've also found another problem, although this is an irritation more than a bug:

calguy1000 wrote:

A new icon for rss feeds

That's irritating because you've swapped a more standard RSS icon for a non-standard, 'fun' one, which means I now have to go back to all my old sites and replace it with the old one, and remember to do so every time there's a new upgrade. It would have been better to implement an rss_icon parameter.

Update: I forgot to say, apart from the bug and the irritant, congratulations and thanks very much to everyone involved!

jwaldeck · **Joined:** Tue Apr 22, 2008 3:42 pm **Posts:** 97

Great job guys, this version looks awesome!

Alby, is a MLE version of 1.4 planed?

Cheers,
jw

calguy1000 · **Posted:** Mon Aug 04, 2008 1:48 pm

I found the issue.... it was a mis typed field name. I'm not sure that this is worth a 1.4.0.1 release (because then I'd have to write a new script to generate diff releases). But here's the fix:

in plugins/function.stylesheet.php:

Code:

Index: function.stylesheet.php
===================================================================
--- function.stylesheet.php     (revision 4914)
+++ function.stylesheet.php     (revision 4915)
@@ -65,7 +65,7 @@
   if (isset($params['name']) && $params['name'] != '')
     {
       $query = 'SELECT css_id FROM '.cms_db_prefix().'css
-                     WHERE name = ?';
+                     WHERE css_name = ?';
       $cssid = $db->GetOne( $query, array($params['name']));
       if( $cssid )
        {

alby · **Posted:** Mon Aug 04, 2008 1:52 pm

jwaldeck wrote:

Great job guys, this version looks awesome!

Alby, is a MLE version of 1.4 planed?

Yes, but I was busy for holiday and follow a Belarus kid that go home today

Alby

stopsatgreen · **Posted:** Mon Aug 04, 2008 2:04 pm

Thanks, Calguy. Will the fixed script be in alll future downloads of 1.4, or will we have to apply this fix to every copy we download?

Code:

I'm not sure that this is worth a 1.4.0.1 release (because then I'd have to write a new script to generate diff releases).

Haven't there been releases before with just a couple of changed pages? Like 1.2 -> 1.2.1? Do you have to write scripts for all of those too?

RonnyK · **Posted:** Mon Aug 04, 2008 2:06 pm

This means that the file is fixed and will be part of next releases, that is not 1.4 off course. So the next release will have this fix inside, that could be 1.4.0.1, 1.4.1 or 1.5 etc....

Ronny

kalozura · **Posted:** Mon Aug 04, 2008 7:30 pm

Quote:

Index: function.stylesheet.php
===================================================================
--- function.stylesheet.php (revision 4914)
+++ function.stylesheet.php (revision 4915)
@@ -65,7 +65,7 @@
if (isset($params['name']) && $params['name'] != '')
{
$query = 'SELECT css_id FROM '.cms_db_prefix().'css
- WHERE name = ?';
+ WHERE css_name = ?';
$cssid = $db->GetOne( $query, array($params['name']));
if( $cssid )
{

I'm trying to fix the stylesheet issue but I'm not sure what I'm supposed to do with this code. do i just add to the this somewhere on the existing file or does it replace it...sorry im not good with php.

alby · **Posted:** Mon Aug 04, 2008 7:40 pm

kalozura wrote:

Quote:

Index: function.stylesheet.php
===================================================================
--- function.stylesheet.php (revision 4914)
+++ function.stylesheet.php (revision 4915)
@@ -65,7 +65,7 @@
if (isset($params['name']) && $params['name'] != '')
{
$query = 'SELECT css_id FROM '.cms_db_prefix().'css
- WHERE name = ?';
+ WHERE css_name = ?';
$cssid = $db->GetOne( $query, array($params['name']));
if( $cssid )
{

I'm trying to fix the stylesheet issue but I'm not sure what I'm supposed to do with this code. do i just add to the this somewhere on the existing file or does it replace it...sorry im not good with php.

Replace row with - in front with row with + in front (= add css_ to name)

Alby

RonnyK · **Posted:** Mon Aug 04, 2008 8:15 pm

kalozura wrote:

Quote:

Index: function.stylesheet.php
===================================================================
--- function.stylesheet.php (revision 4914)
+++ function.stylesheet.php (revision 4915)
@@ -65,7 +65,7 @@
if (isset($params['name']) && $params['name'] != '')
{
$query = 'SELECT css_id FROM '.cms_db_prefix().'css
- WHERE name = ?';
+ WHERE css_name = ?';
$cssid = $db->GetOne( $query, array($params['name']));
if( $cssid )
{

I'm trying to fix the stylesheet issue but I'm not sure what I'm supposed to do with this code. do i just add to the this somewhere on the existing file or does it replace it...sorry im not good with php.

Check this post http://forum.cmsmadesimple.org/index.ph ... 395.0.html and find the modified file attached there...

Ronny

kalozura · **Posted:** Mon Aug 04, 2008 9:12 pm

Thanks Alby

nuno · **Posted:** Mon Aug 04, 2008 9:40 pm

Quote:

That's irritating because you've swapped a more standard RSS icon for a non-standard, 'fun' one, which means I now have to go back to all my old sites and replace it with the old one, and remember to do so every time there's a new upgrade. It would have been better to implement an rss_icon parameter.

so, you say the old rss icon (XML-icon) is more cool-standart than the new one?

Ziggywigged · **Posted:** Tue Aug 05, 2008 12:36 am

mikeim wrote:

1. Using TinyMCE, when linking to an uploaded file from the file manager it creates the url as: /www.site.com/uploads/...
and so this creates an incorrect and broken link. I have 'Generate relative urls' checked in my settings.

Can anyone suggest a fix for this?
Thanks.

alby · **Posted:** Tue Aug 05, 2008 2:56 pm

mikeim wrote:

1. Using TinyMCE, when linking to an uploaded file from the file manager it creates the url as: /www.site.com/uploads/...
and so this creates an incorrect and broken link. I have 'Generate relative urls' checked in my settings.

Can anyone suggest a fix for this?

I tested and I see a correct "final" behavior.

- "generate relative url" checked
- in Tiny Link to internal file, now in tiny source I have /uploads/file.pdf in link
- APPLY button and check in source html: tiny drop first / and I see the correct link: upload/file.pdf

Alby

Announcing CMS Made Simple v1.4 "Jamaica"

Who is online