Patriciaaaaaaaaa :D -- I got IT!!!

nuspace · **Posted:** Tue Nov 08, 2005 1:49 am

Just a bit more info about the disappearing slashes. I tried moving a subdomain cms.domain.com to www.domain.com and it still didn't work. But then when I moved it to a subdirectory www.domain.com/cms the problem disappeared. So it seems there must have been an assumption made somewhere that CMSMS would always be installed in a subdirectory...

Patricia · **Posted:** Tue Nov 08, 2005 5:29 am

My tests:

I tried comment that line 98

Code:

$offsetPath = substr($offsetPath, strpos($offsetPath, "/"));

and it solved the strip subfolder and slash issue.

but as this line must certainly be there for something.... I'm not sure what to do, and I tried on a subdomain, choosing image on subfolder of image.

Now without that there is still the thing that the runtime editor doesn't see the images created with TinyMCE (which path are uploads/images/... instead of sub/uploads/images/...), so not suitable for existing sites which were using TinyMCE or with choice for both editors. Also FCK save sub/uploads/images/... in db, when I edit without wysiwyg I see that mistake.

and also, if I try to change some other lines around line 98 (my tests

when I save firefox says: "a script on this page is causing mozilla to run slowly..."

So I know it's somewhere there, but I have no more idea, as how OffsetPath is then sent from php to javascript and where the runtime editor use that variable. Not much more idea about it.

nuspace · **Posted:** Tue Nov 08, 2005 7:44 am

Okay, thanks to Patricia for pointing me in the right direction. I think I've found why the slashes are being stripped. Here's how offsetPath is being obtained (some commented out lines omitted):

Code:

    $offsetPath = $this->cms->config["uploads_url"];
    $offsetPath = str_replace( 'http://', '', $offsetPath );
    $offsetPath = substr($offsetPath, strpos($offsetPath, "/"));
    $offsetPath = str_replace( 'uploads', '', $offsetPath );

Now, this deletes the http://, the domain, and the string 'uploads'. So if we don't use a subdirectory in the uploads URL (say 'http://www.domain.com/uploads') all that's left in $offsetPath is the slash.

Further down, here's what's being done:

Code:

      while (obj1.value.search(offsetPath) > 0)
        obj1.value = obj1.value.replace(offsetPath,"");

So, since $offsetPath is equal to "/", all slashes in the HTML are being deleted, including those in the tag endings.

Question to megabob3: is there a particular reason why the string 'uploads' needs to be deleted from $offsetPath? The only other place I can see that variable being used is here:

Code:

$oFCKeditor->Value = str_replace('src="uploads', 'src="'.$offsetPath.'uploads', $content) ;

and it seems 'uploads' is being added back on anyway?

Bear in mind that I've only looked at the code very superficially, and for all I know there might be a good reason. At this point though it seems to me that leaving 'uploads' in there would fix the problem.

As for Patricia's problem with compatibility with TinyMCE, you could probably hardcode $offsetPath to 'uploads' and that would give you a relative path from the current directory... (haven't tested, sorry)

nuspace · **Posted:** Tue Nov 08, 2005 8:23 am

Oops, seems like I wasn't looking at the latest version of the code... But I think the analysis still holds.

nuspace · **Posted:** Tue Nov 08, 2005 8:35 am

Okay, from my preliminary tests, this seems to do the trick. First comment out this line:

Code:

$offsetPath = str_replace( 'uploads', '', $offsetPath );

And then change this line:

Code:

$oFCKeditor->Value = str_replace('src="uploads', 'src="'.$offsetPath.'uploads', $content) ;

to this:

Code:

$oFCKeditor->Value = $content;

I just hope there are no unwanted side effects...

nuspace · **Posted:** Tue Nov 08, 2005 8:41 am

Sorry, actually no, that doesn't work. I was testing the wrong site. Must be time to call it a day...

megabob3 · **Posted:** Tue Nov 08, 2005 1:01 pm

I am doing ALL like if start all from beginning.

I am studying REGULAR EXPRESSION, into javascript.

And doing the replacement only into TAGs.

Like is now was the problem that replace everything.

For example into content one thing is replace into double quote the "e; from showed information and another thing is replace from {smarty tag}

Using regular expression will all different, please wait few days.

See You All

Patriciaaaaaaaaa :D -- I got IT!!!

Who is online