Typo in 1.11.13 install(s)?

[fredp]

Hi,

I just tried to upgrade from 1.11.12 to 1.11.13 using cmsmadesimple-english-diff-1.11.12-1.11.13.tar.gz. I ended up with a white screen after the untar; so, I checked the apache2 log and found the following error:

PHP Fatal error: Call to undefined function uniquid() in /home/username/public_html.test/include.php on line 53

Line 53 appears to be:

Code: Select all

...
        session_id( uniquid() );
...

Should this call be to uniqid() rather than uniquid()?

Edit: Update
For testing purposes, I changed uniquid() to uniqid() on line 53. That resolved the white screen issue. I was able to login to the admin console again and perform various admin functions without error.

I'll create a bug report, if that would be helpful.

Hope this helps,
---Fred P.

[Rolf]

We will look into this. Thank you!

[Rolf]

Out of curiosity, could you post the System Information of the website here?

[fredp]

Hi Rolf,

Per your request, here is the System Information from my test installation.

Cms Version: 1.11.13
Installed Modules:
CMSMailer: 5.2.2
CMSPrinting: 1.0.5
FileManager: 1.4.5
MenuManager: 1.8.6
ModuleManager: 1.5.8
News: 2.15
TinyMCE: 2.9.12
Gallery: 1.6.1
FormBuilder: 0.8.1.1
fp_visit_stats: 1.1
fp_email_utils: 1.1
fp_img_utils: 1.2
fp_tim: 1.5

Config Information:
php_memory_limit:
process_whole_template:
max_upload_size: 64000000
url_rewriting: mod_rewrite
page_extension: .html
query_var: page
image_manipulation_prog: GD
auto_alias_content: true
locale:
default_encoding: utf-8
admin_encoding: utf-8
set_names: true

Php Information:
phpversion: 5.4.20
md5_function: On (True)
gd_version: 2
tempnam_function: On (True)
magic_quotes_runtime: Off (False)
E_STRICT: 0
E_DEPRECATED: 0
memory_limit: 128M
max_execution_time: 30
output_buffering: 4096
safe_mode: Off (False)
file_uploads: On (True)
post_max_size: 64M
upload_max_filesize: 64M
session_save_path: /home/username/tmp_sessions (0770)
session_use_cookies: On (True)
xml_function: On (True)
xmlreader_class: On (True)

Server Information:
Server Api: apache2handler
Server Db Type: MySQL (mysqli)
Server Db Version: 5.5.33
Server Db Grants: Found a "GRANT ALL" statement that appears to be suitable
Server Time Diff: No filesystem time difference found

[so what?]

Hi Rolf,

according to the php documentation on php.net there exists only a function uniqid(). If you search for uniquid you'll get:
uniquid doesn't exist. Closest matches: uniqid (and a list of other functions). See http://php.net/manual-lookup.php?patter ... e=quickref

So I guess it is a typo which should be corrected.

Fanny though I upgraded 4 sites and had no problems with it. The sites work and so do the admin-pages. All those sites run php 5.5.21 and not 5.4.20 as the site of Fred P. does. This might explain the different behaviors. Or maybe not. Since I can change php versions easily, I changed it on one site to 5.4.37 - the only 5.4 version my hoster provides - and had no troubles at all. The same applies to php version 5.6.5.

I hope I could help a little with these infos.

[Rolf]

Thanks for the info.

We already fixed it in the SVN yesterday, but it puzzles me why this error appears at the website of Fredp and not when we tested it at our test sites. I also upgraded several of my websites at different web servers before we released 1.11.13 and none had this error...

[fredp]

I copied include.php from SVN and it resolved the problem on my 5.4.20 test server. Thanks for the fix!

As an aside, it is curious why others aren't seeing this error. I made a quick test on a different server running PHP 5.5.21 and it doesn't like uniquid() calls either:

I put this code into file test123.php:

Code: Select all

<?php echo "PHP Version ". PHP_VERSION; ?> <br />
<?php echo uniquid(); ?>

But browsing test123.php displays only:

Code: Select all

PHP Version 5.5.21

No unique id value is shown and the following error appears in error_log:

...PHP Fatal error: Call to undefined function uniquid() in /home3/username/public_html/test123.php on line 2

I have PHP error_reporting = E_ALL & (~E_STRICT & ~E_DEPRECATED)

Perhaps others aren't seeing these errors because they are somehow including their own function named uniquid()?

Anyway, thanks again for the fix!
I'll mark this thread solved once the fix appears in a release.